MIT-LAE / TASOPT.jl

Medium fidelity aircraft-propulsion system design and optimization.
https://mit-lae.github.io/TASOPT.jl/
MIT License
26 stars 12 forks source link

Homogeneous model of cryogenic tanks #40

Closed ngomezve closed 3 months ago

ngomezve commented 4 months ago

This PR introduces a homogeneous model for a cryogenic tank. This treats the fluid inside the tank as a mixture of a saturated liquid and a saturated vapor. Through this, TASOPT can model the evolution of pressure in time inside the tank, as well as calculate the required venting more accurately. In addition, this PR also:

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 55.76923% with 161 lines in your changes are missing coverage. Please review.

Project coverage is 74.44%. Comparing base (c224dd9) to head (ad57395). Report is 36 commits behind head on main.

Files Patch % Lines
src/cryo_tank/tanktools.jl 0.00% 131 Missing :warning:
src/sizing/wsize.jl 0.00% 14 Missing :warning:
src/cryo_tank/pressure.jl 79.66% 12 Missing :warning:
src/IO/read_input.jl 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== - Coverage 74.73% 74.44% -0.30% ========================================== Files 69 71 +2 Lines 13089 13381 +292 ========================================== + Hits 9782 9961 +179 - Misses 3307 3420 +113 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ngomezve commented 4 months ago

My next PR will introduce a regression test for a hydrogen aircraft sizing that will improve test coverage.

ngomezve commented 4 months ago

Updated to remove merge conflicts with PR 42

ngomezve commented 3 months ago

The ODE solver in DifferentialEquations.jl is now used instead of the custom RK4 one.