search

MIT-LAE / TASOPT.jl

Medium fidelity aircraft-propulsion system design and optimization.
https://mit-lae.github.io/TASOPT.jl/
MIT License
26 stars 12 forks source link

Fix tail sizing bug #5

Closed askprash closed 9 months ago

askprash commented 9 months ago

Fixes #4

Was caused by the tail volume coefficient incorrectly being initialized to zero, which was in turn leading to a divide by zero that gave a NaN for CLh, this propagated through till where it broke. Added error messages too.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fe7ca94) 57.98% compared to head (11301b0) 58.04%.

Files Patch % Lines
src/aero/airfun.jl 92.30% 5 Missing :warning:
src/IO/read_input.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5 +/- ## ========================================== + Coverage 57.98% 58.04% +0.06% ========================================== Files 66 65 -1 Lines 12456 12443 -13 ========================================== + Hits 7222 7223 +1 + Misses 5234 5220 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.