Closed askprash closed 1 month ago
Fixed #68
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 58.49858%
with 293 lines
in your changes missing coverage. Please review.
Project coverage is 71.88%. Comparing base (
78ba4b2
) to head (cb36835
). Report is 34 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/IO/save_model.jl | 0.00% | 147 Missing :warning: |
src/structures/loads.jl | 54.79% | 33 Missing :warning: |
src/misc/fuselage_geometry.jl | 66.66% | 32 Missing :warning: |
src/structures/update_fuse.jl | 44.11% | 19 Missing :warning: |
src/misc/materials.jl | 31.57% | 13 Missing :warning: |
src/IO/quicksave_load.jl | 0.00% | 10 Missing :warning: |
src/sizing/wsize.jl | 78.04% | 9 Missing :warning: |
src/IO/read_input.jl | 87.69% | 8 Missing :warning: |
src/balance/balance.jl | 75.86% | 7 Missing :warning: |
src/misc/layout.jl | 84.61% | 4 Missing :warning: |
... and 6 more |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@aditeyashukla starting a draft PR here so that others can also see what we've been up to and add any suggestions.
This PR refactors the fuselage sizing code to be more modular, easy to read and more efficient.
Some of the updates/features:
Fuselage
,FuselageLayout
, and a couple other types that make it easier to define and size the fuselageStructuralMembers
are a generic type that can be used to represent various structural components - e.g., in the fuselage this may be the skin, the floor, etc.loads.jl
that has lets us defineWeights
and more semantically calculate the moments of weights. Also have some basic coordinate system introduced (e.g., now we can associate loads/ weights with aFrame
which defaults to a privilegedWORLD
frame. This can allow us to translate between frames more easily. We may potentially replace this with homogenous coordinates if we start to find it useful enough.