codecov-commenter
commented
4 months ago Codecov Report
Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
Project coverage is 78.26%. Comparing base (
78ba4b2) to head (5a0bb58). Report is 16 commits behind head on main.:exclamation: Current head 5a0bb58 differs from pull request most recent head 04ec52c
Please upload reports for the commit 04ec52c to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| src/IO/read_input.jl | 50.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== + Coverage 76.41% 78.26% +1.85% ========================================== Files 69 71 +2 Lines 13169 13418 +249 ========================================== + Hits 10063 10502 +439 + Misses 3106 2916 -190 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR revisits the old functions to place seats, originally developed for output visualization only. The old functions could only handle symmetric seating or asymmetric seating of 3 or 5 passengers.
The new functions use a dictionary with the seating layout precomputed for up to 16 passengers per row. By selecting the maximum number of seats per row possible for a given fuselage radius, this can also be used to resize the fuselage diameter in smaller steps than before. The old distinction between symmetric and asymmetric layouts has been removed as the code is agnostic to it.
This PR also addresses issue #27 by introducing a floor separation parameter in the cases when the aircraft is a double decker. The two floors are assumed to be distributed symmetrically inside the cross section, which can be a double bubble.