search

MIT-LAE / TASOPT.jl

Medium fidelity aircraft-propulsion system design and optimization.
https://mit-lae.github.io/TASOPT.jl/
MIT License
26 stars 12 forks source link

Double-bubble cryogenic tanks #64

Closed ngomezve closed 1 day ago

ngomezve commented 2 months ago

This PR removes inconsistencies in the geometry of the cryogenic tanks in the fuselage. Some models assumed that the geometry was a double bubble while others only applied to circular sections. Now, the tank cross-section can be a double bubble in general, following the fuselage section.

This PR also introduces a new function double_bubble_geom() that can be used to calculate the geometric properties of a double bubble shape. This function could also be used in fuseW for the fuselage design.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.87500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (78ba4b2) to head (1ec6ace). Report is 32 commits behind head on main.

Files Patch % Lines
src/cryo_tank/tankWmech.jl 94.11% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #64 +/- ## ========================================== + Coverage 76.41% 78.34% +1.92% ========================================== Files 69 72 +3 Lines 13169 13460 +291 ========================================== + Hits 10063 10545 +482 + Misses 3106 2915 -191 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ngomezve commented 1 day ago

Closing as superseded by PR #80.