Closed ngomezve closed 1 day ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 96.87500%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 78.34%. Comparing base (
78ba4b2
) to head (1ec6ace
). Report is 32 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/cryo_tank/tankWmech.jl | 94.11% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing as superseded by PR #80.
This PR removes inconsistencies in the geometry of the cryogenic tanks in the fuselage. Some models assumed that the geometry was a double bubble while others only applied to circular sections. Now, the tank cross-section can be a double bubble in general, following the fuselage section.
This PR also introduces a new function
double_bubble_geom()
that can be used to calculate the geometric properties of a double bubble shape. This function could also be used infuseW
for the fuselage design.