MIT-LAE / TASOPT.jl

Medium fidelity aircraft-propulsion system design and optimization.
https://mit-lae.github.io/TASOPT.jl/
MIT License
26 stars 14 forks source link

Fixing issue with linear algebra threads #65

Closed ngomezve closed 3 months ago

ngomezve commented 3 months ago

This PR is a simplified version of PR #58. It just adds the final fix that we found for the LU decomposition issue in blax(), which would take 3 orders of magnitude longer on a server with 1 CPU than it should.

The issue is resolved by setting the number of threads in the OpenBLAS linear algebra library to 1, to avoid any parallelization. Note that this may become an issue in the future if explicit parallelization is attempted in TASOPT. For now, it should provide significant speed improvements if run on a server.

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.27%. Comparing base (78ba4b2) to head (a1371a0). Report is 22 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ========================================== + Coverage 76.41% 78.27% +1.85% ========================================== Files 69 71 +2 Lines 13169 13420 +251 ========================================== + Hits 10063 10504 +441 + Misses 3106 2916 -190 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.