MIT-LAE / TASOPT.jl

Medium fidelity aircraft-propulsion system design and optimization.
https://mit-lae.github.io/TASOPT.jl/
MIT License
26 stars 15 forks source link

Improve `sized` flag logic #99

Open argonaut22 opened 2 days ago

argonaut22 commented 2 days ago

@argonaut22 added a field to the aircraft struct to indicate if a model is sized. Right now it's v naive (namely, reaching the end of wsize).

We should figure out how to do this more robustly (e.g., not setting ac.sized = True if wsize() doesn't converge or if a driving parameter is changed [this may depend on determining "design parameters"])

ngomezve commented 2 days ago

This is a very good idea, @argonaut22. In my code, I artificially set some fields to NaN if the sizing fails, but an approach such as this is much better.