MIT-LCP / mimic-code

MIMIC Code Repository: Code shared by the research community for the MIMIC family of databases
https://mimic.mit.edu
MIT License
2.51k stars 1.5k forks source link

Avoid unnecessary dependency on sqlalchemy #1455

Closed bemoody closed 1 year ago

bemoody commented 1 year ago

sqlite/import.py provides a quick and easy way to import MIMIC-IV into SQLite format. As far as I can see, there's no reason for this script to be dependent on sqlalchemy.

(I'd remove the pandas dependency too, but pandas is actually serving a purpose here by auto-detecting some of the column types.)

Granted, I haven't actually used sqlalchemy and I don't know if it provides any special benefits here. I also only tested this on the demo (https://physionet.org/content/mimic-iv-demo/1.0/). Let me know if you want me to do more extensive testing.

It's a minor thing, but it's nice to have one fewer dependency to worry about.