MIT-LCP / mimic-code

MIMIC Code Repository: Code shared by the research community for the MIMIC family of databases
https://mimic.mit.edu
MIT License
2.51k stars 1.5k forks source link

Add linting of SQL files using sqlfluff #1480

Closed alistairewj closed 1 year ago

alistairewj commented 1 year ago

There is a package for linting SQL files called sqlfluff (GitHub link).

I've added a rule file using the simplest core rules plus L019 which enforces leading commas. Importantly, this PR has no functional changes, and only the application of sqlfluff fix to the mimic-iv/concepts subfolder. Further, some rules were skipped on a file-specific level to ensure that the conversion to PostgreSQL scripts would still work.

I've also added a GitHub action which should verify that files are appropriately linted on a PR and annotate errors if they are found. Haven't tested it yet though, so here goes nothing :)