MIT-LCP / mimic-code

MIMIC Code Repository: Code shared by the research community for the MIMIC family of databases
https://mimic.mit.edu
MIT License
2.43k stars 1.5k forks source link

MIMIC-IV-Notes loading scripts behave differently than base loading scripts #1530

Open tsteffek opened 1 year ago

tsteffek commented 1 year ago

Prerequisites

Description

mimic_data_dir in e.g. mimic-iv/.../loag_gz.sql expects to be the root directory of MIMIC-IV dataset. Afterwards it cds into the respective schemas and copies. For the mimic-vi-note postgres loading scripts, mimic_data_dir is expected to be position in the note subfolder of MIMIC-VI-Notes, the cd note is missing in all 3 of them.

If you confirm that this is not intentional I can also send you a quick PR if you consider that easier.

alistairewj commented 1 year ago

Ah yeah OK I think consistency is better so having it cd into note makes sense. Same story for ED data if it has the same issue.