search

MIT-LCP / mimic-code

MIMIC Code Repository: Code shared by the research community for the MIMIC family of databases
https://mimic.mit.edu
MIT License
2.52k stars 1.51k forks source link

Some derived concepts missing on BigQuery #952

Closed JHLiu7 closed 3 years ago

JHLiu7 commented 3 years ago

Thanks for the new release on both the dataset and the codebase! I noticed the make_concepts.sh to create derived views does not include all the queries in the concept directory. I wonder if that is causing stay_id in tables like physionet-data.mimic_derived.sepsis3 on BigQuery to be out of joint with the rest of the dataset. I also couldn't find tables for charlson and kdigo_*. Did I miss anything? Thanks!

alistairewj commented 3 years ago

Oh I didn't realize make concepts wasn't exhaustive. Let me take a look!

alistairewj commented 3 years ago

Should be fixed now!

JHLiu7 commented 3 years ago

Great! But just to let you know, I think physionet-data.mimic_derived.sepsis3 is empty right now. The other tables look good to me though

alistairewj commented 3 years ago

Ah thanks, it's there now.. need to figure out a better way to order the table builds in make_concepts.sh beyond the brittle if statements.