search

MIT-LCP / mimic-omop

Mapping the MIMIC-III database to the OMOP schema
MIT License
123 stars 47 forks source link

Should `qualifier` in scripts for procedure_occurrence be `modifier`? #37

Closed alistairewj closed 6 years ago

alistairewj commented 6 years ago

Got this error when rerunning the ETL

psql:omop/build-omop/postgresql/mimic-omop-alter.sql:70: ERROR:  column "qualifier_source_value" of relation "procedure_occurrence" does not exist

Looking at the docs https://github.com/OHDSI/CommonDataModel/wiki/PROCEDURE_OCCURRENCE - should this instead refer to modifier?

parisni commented 6 years ago

Looks like they updated the model in between: The ddl are there omop/build-omop/postgresql/omop_ddl_comments.sql We might make them update, but right now the ETL is sync with the above

2018-03-26 19:46 GMT+02:00 Alistair Johnson notifications@github.com:

Got this error when rerunning the ETL

psql:omop/build-omop/postgresql/mimic-omop-alter.sql:70: ERROR: column "qualifier_source_value" of relation "procedure_occurrence" does not exist

Looking at the docs https://github.com/OHDSI/CommonDataModel/wiki/ PROCEDURE_OCCURRENCE - should this instead refer to modifier?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MIT-LCP/mimic-omop/issues/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AJF_dl7Wp-OxWYX8DMKC8I_2e1f2xdQKks5tiSlxgaJpZM4S7n2a .

alistairewj commented 6 years ago

OK sounds good. I am refactoring the ETL, perhaps we could have a call tomorrow if you are available.