MIT-LCP / mimic-omop

Mapping the MIMIC-III database to the OMOP schema
MIT License
128 stars 48 forks source link

vocabulary_reference not null constraint on loading vocab using omop_vocab_load script #55

Open FadyRezkGhattas opened 6 years ago

FadyRezkGhattas commented 6 years ago

Related to issue in CommonDataModel: https://github.com/OHDSI/CommonDataModel/issues/233

That has been solved in CommonDataModel repository through a 5 day old commit: https://github.com/kids-first/CommonDataModel/commit/b53f6965eee975733ceec992a04c921beec72d54

However, in the tutorial here: https://github.com/MIT-LCP/mimic-omop/blob/master/omop/build-omop/postgresql/README.md we reset the CDM repository to a commit from march missing on the above fix. Therefore, I still get the same null constrained while loading Athena vocab even though fixed in the issue above.

I tried cloning the latest CDM repository and following the tutorial without resetting the code to march but still getting the same output error.

Therefore, what I did was follow the tutorial but after resetting to the march commit, I followed the changes in the bug fix from CDM to edit the relevant files in my local copy and then continued following the tutorial.

That worked fine but not sure if it will cause any problems as I continue doing the ETL.