search

MIT-LCP / physionet-build

The new PhysioNet platform.
https://physionet.org/
BSD 3-Clause "New" or "Revised" License
56 stars 20 forks source link

Request both completion certificate and report #1610

Open alistairewj opened 2 years ago

alistairewj commented 2 years ago

For CITI training, why don't we request users upload both the certificate and the report?

It seems like it would reduce the number of errors made.

rgmark commented 2 years ago

I agree! The two terms are confusing...so getting both solves the problem! Roger

On 6/18/2022 9:29 AM, Alistair Johnson wrote:

For CITI training, why don't we request users upload both the certificate and the report?

It seems like it would reduce the number of errors made.

— Reply to this email directly, view it on GitHub https://github.com/MIT-LCP/physionet-build/issues/1610, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYOOSR2HAHLYETGUEXWH3TVPXFMLANCNFSM5ZEYQOLA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Roger G. Mark, M.D., Ph.D. Distinguished Professor in Health Sciences and Technology, Post-tenure Institute of Medical Engineering and Science Room E25-505 MIT Cambridge, MA 02139 Tel 617-253-7818 Cell 617-359-2429 Fax 617-258-7859

tompollard commented 2 years ago

Previously the training form validator prevented upload of certificates, so this wasn't an issue. Commit https://github.com/MIT-LCP/physionet-build/commit/dcafd1c1ab9947b569fdce5ab0a39b843d6d8c39 broke this validation.

I would prefer fix the validation than to request certificates (unless we are using the certificates for something). See See: https://github.com/MIT-LCP/physionet-build/issues/1600 for more detail.

tompollard commented 2 years ago

@bemoody as a temporary hack, would you be okay with putting the validation code into a if training_type_name == "CITI Data or Specimens Only Research": ... block? This quick fix would be a significant help to the people doing training checks.