MIT-LCP / physionet-build

The new PhysioNet platform.
https://physionet.org/
BSD 3-Clause "New" or "Revised" License
55 stars 19 forks source link

Developer Checklist for PRs & Issues #2212

Closed Rutvikrj26 closed 1 month ago

Rutvikrj26 commented 3 months ago

What:

This pull request is to open a discussion on what checks and guidelines can we introduce to ensure the pull requests are easy to go through and merge.

The discussion on this pull request will finally be incorporated into the Development.

Current Ideas:

Checklist:

  • Make sure you have tested your changes locally.
  • Make sure you have added the necessary test cases for your changes.
  • Make sure you have added the necessary documentation for your changes.
    • Added one-liner crisp comments describing the logic flow.
    • Added Docstrings to any new functions written.
    • Updated the README.md file with the necessary information.
  • Updated the Requirements.txt for any new dependencies added. (Auto-generated from Poetry using poetry export command)
  • Make sure you have added the necessary changes to the .env.example file.