MIT-LCP / physionet-build

The new PhysioNet platform.
https://physionet.org/
BSD 3-Clause "New" or "Revised" License
56 stars 20 forks source link

Blank ethics_statement is allowed #2239

Closed bemoody closed 1 week ago

bemoody commented 4 months ago

If ethics_statement is set to <p>&nbsp;</p>, or something similar, the field is not flagged as a "missing required field".

See check_integrity in activeproject.py; look at line 349, and compare to the code immediately above it.

bemoody commented 3 months ago

It might be reasonable for SafeHTMLField to automatically replace blank HTML content with an empty string.

Another example is that if you set an optional section to <p>&nbsp;</p>, the section should be hidden, but I'm not sure that happens currently.