search

MIT-LCP / physionet-build

The new PhysioNet platform.
https://physionet.org/
BSD 3-Clause "New" or "Revised" License
56 stars 20 forks source link

Should merging to dev trigger Shippable to re-run tests on pull request branches? #710

Open tompollard opened 5 years ago

tompollard commented 5 years ago

Suggested by @lbulgarelli. Should merging a branch to dev trigger Shippable to re-run tests for all pull request branches?

If the tests are not triggered upon merges to dev, then a pull request may appear to be passing tests, but may actually fail when merged (e.g. because migrations are out of sync).

tompollard commented 5 years ago

It looks like we can configure hooks using the instructions at: http://blog.shippable.com/configure-web-hooks-to-trigger-continuous-integration

Oddly though, I don't see the "subscriptions" item in the menu. It definitely used to be there, but isn't now. Looks like other people have had this issue too: https://github.com/Shippable/support/issues/3850

I've checked the third party integration status for the github organization, which says "No restrictions" so this isn't the problem. Also tried resyncing as suggested, but I get a time out. Will try again later...