search

MIT-LCP / physionet-build

The new PhysioNet platform.
https://physionet.org/
BSD 3-Clause "New" or "Revised" License
56 stars 20 forks source link

LightWAVE with huge number of signals #806

Open bemoody opened 4 years ago

bemoody commented 4 years ago

One problem with LightWAVE is that very long URLs (/lightwave/server?action=fetch&signal=1&signal=2&signal=3&signal=4&...) get rejected by uwsgi with the message "invalid request block size".

Should we change the block size (https://stackoverflow.com/a/26941287) to tolerate longer URLs? Will that even work? Will it create DoS issues?

It'd be better, of course, for lightwave to avoid requesting huge numbers of signals at once. (Though obviously we could also encode the query more efficiently.)

It'd be much better for lightwave to avoid trying to display huge numbers of signals at once.

Really making this work well requires revamping the lightwave UI.

Lucas-Mc commented 4 years ago

I just experience this issue with this project I'm working on. I think this should be re-visited.. is it possible to make LightWave take up more of the page vertically? Or create multiple "copies" of the graph? This could allow the current max signals to be placed on one graph and the remaining placed on another and so forth. ... Though my current preference would be to have them on the same graph somehow without reducing their vertical space to preserve signal profile.