MIT-LCP / waveform-annotation

Platform for annotating physiological waveform data.
11 stars 4 forks source link

Next/Previous annotation buttons not working #1

Closed lilehman closed 3 years ago

lilehman commented 4 years ago

The next/previous annotation buttons appear to not work on my laptop running windows 10, firefox. Nothing happened after clicking on them. If I recall correctly, they were working in the previous version.

Lucas-Mc commented 4 years ago

Hey @lilehman, thanks for letting me know! Is there a specific chain of requests you make to re-create the error i.e. only on initial load, after requesting a certain annotation, etc? I am not seeing this on Mac Firefox but will break out the Windows machine to try and re-create it!

lilehman commented 4 years ago

I did more testing and here is the summary.

On this current laptop, the problem exists in both Firefox and Chrome. So, when I create new firefox / chrome windows, the problem persists.

However, when I try run the tool on a second laptop I have, also windows 10, firefox, the buttons work fine!

So, it might be specific to the first laptop, or triggered by some sequence of operations I did on that first laptop. I'll try to reboot and let you know.

lilehman commented 4 years ago

I just rebooted my first laptop and the problem still persists for both firefox and chrome.

Since it works fine on my other laptop, I suggest that this would be low priority unless others are also having same issues. OK by me if we close the issue for now, and reopen later.

If this helps, I discovered that on my first laptop, for BOTH firefox and chrome, clicking on the next/previous button will cause the browser to reload the same record again. I only get to notice this when I click on next/prev, after doing the zoom/pan on the waveforms, (so that the waveforms would look different than when it's first loaded).

Lucas-Mc commented 4 years ago

Thanks for the additional information! I've heard another comment with the same issue and I want to try and find similarities between the two... It's possible there could be something involved with HTTPS requirements or extensions (HTTPS Everywhere, etc.) but I have to look further, updates to come!

rgmark commented 4 years ago

doesn't work on my Win machine, either.

On 11/18/2020 10:09 AM, Li-wei Lehman wrote:

I did more testing and here is the summary.

On this current laptop, the problem exists in both Firefox and Chrome. So, when I create new firefox / chrome windows, the problem persists.

However, when I try run the tool on a second laptop I have, also windows 10, firefox, the buttons work fine!

So, it might be specific to the first laptop, or triggered by some sequence of operations I did on that first laptop. I'll try to reboot and let you know.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MIT-LCP/waveform-annotation/issues/1#issuecomment-729742218, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYOOSSX22WIGDG7NYHTWYTSQPPUJANCNFSM4T2CDSDA.

-- Roger G. Mark, M.D., Ph.D. Distinguished Professor in Health Sciences and Technology, Post-tenure Institute of Medical Engineering and Science Room E25-505 MIT Cambridge, MA 02139 Tel 617-253-7818 Cell 617-359-2429 Fax 617-258-7859

Lucas-Mc commented 4 years ago

No apparent problems on the sever side based on the logs as suspected, must be client side specific to that combination of OS and browser.

Lucas-Mc commented 3 years ago

Unfortunately, I can't seem to reproduce the issue on my Windows machine... When you load the page and notice the issue, have you checked the Developer Tools (Ctrl+Shift+I or F12) console output? There should already be a circular dependencies warning but that shows up even when the buttons work.. Hopefully that may point us in the right direction to finding the issue!

EDIT: I even tried it after updating to the most recent version of Chrome and setting HTTPS Everywhere to the strictest requirements.. strange!

Lucas-Mc commented 3 years ago

I think this has been resolved so I'll close it but keep an eye on it since I can't pinpoint an exact change that fixed this.