MIT-LCP / waveform-annotation

Platform for annotating physiological waveform data.
11 stars 4 forks source link

Added record assignments to users based on CSV file #19

Closed Hsaeedx closed 3 years ago

Hsaeedx commented 3 years ago

Users start off with 0 records to annotate. Users can press a button to request records by pressing a button under the "View current annotations" tab, which can be accepted by admins on the admin console. Accepting this request updates a the records.csv file to include the new assignments, and users can then view these added requests.


*Added record_assignments.csv file

*Modified User model to include a boolean value of whether they requested records, and when that request was made

*Updated views.py to allow users to make record requests in view current annotations tab, and now only shows records assigned based on csv file. Admin console was updated to allow admins to accept requests.

Lucas-Mc commented 3 years ago

Hey Hasan, so some other things to note:

  1. Do you assign records to people instead of events? It seems like during the demo you said the default was set to 20, but the user was actually assigned 44 which corresponds to 20 records with multiple events for each record. It should be 20 events instead.
  2. A little bug, but the button stayed "Request Pending" on the user side even after it was accepted by an admin.
  3. Another bug, on the admin page every request shows up even after it has already been accepted once the user leaves and comes back (I know by logging out and in again but maybe other ways too).
Hsaeedx commented 3 years ago

Hey Hasan, so some other things to note:

  1. Do you assign records to people instead of events? It seems like during the demo you said the default was set to 20, but the user was actually assigned 44 which corresponds to 20 records with multiple events for each record. It should be 20 events instead.

I'm currently in the process of assigning events instead of records.

  1. A little bug, but the button stayed "Request Pending" on the user side even after it was accepted by an admin.
  2. Another bug, on the admin page every request shows up even after it has already been accepted once the user leaves and comes back (I know by logging out and in again but maybe other ways too).

As for these other two, can you tell me the steps you took to get these bugs? I wasn't able to recreate either of them.

https://user-images.githubusercontent.com/62735550/128218919-20cb0900-1823-48de-a76e-d83cd29f75f0.mp4