MIT-LCP / wfdb-python

Native Python WFDB package
MIT License
738 stars 300 forks source link

Third loop in wfdb.processing.peaks.find_local_peaks will not be executed and can be removed #474

Open mj-64 opened 10 months ago

mj-64 commented 10 months ago

In find_local_peaks() in wfdb.processing.peaks, the last of three loops will not be execute because the condition i < len(sig) is already false when the second loop exits: [first loop omitted]

while i < len(sig):
    if sig[i] == max(sig[i - radius : i + radius]):
        peak_inds.append(i)
        i += radius
    else:
        i += 1

while i < len(sig):
    if sig[i] == max(sig[i - radius :]):
        peak_inds.append(i)
        i += radius
    else:
        i += 1