News tweaks - Githubissues

justinanderson commented 10 years ago

General

[x] Still occassionally seeing media type cells with too much height.
[x] Instead of "less than 1 minute ago", toolbar should say "Just Now".
[x] Don't show Load More when there's no "next" link in the Link header. A search for "potato india" returns 2 results, and shouldn't show a Load More button. A search for krugman has 29 results, so it should show Load More for the first screenful and then not have a Load More button after the rest has been loaded.
[x] Don't say "Update Failed" in News toolbar. Just show the time the current data is fresh as of. Only show a failure message if the failed refresh was a manually started one, and show the message in an alert.
[x] If you tap a cell after the data contents are replaced, but before the table is reloaded, you may be directed to the wrong story.
[x] Stories aren't updating on a refresh.

Root

[ ] Add back Featured section once the News Office API starts returning featured stories in the right order.
[x] Stories aren't sorted in the same order on the root screen as they are on the category list screen. For example, when the Root screen loads this for In the Media it shows the Wired story before the space.com story. When the Category screen loads this, the space.com story is sorted first. The two screens should agree on a sort order.

Searching

[x] Instead of adding and removing a UISearchBar to the top of the UITableViews in News and then animating that into a focused state, we should do more like Apple's Calendar app and jump straight to the end state without animation. The interaction should go from browsing to search with nothing else going on between those two frames.
[x] News Top List and Category List tableviews shouldn't scroll to the top when the search field is focused. Their scroll position should be unaffected by searching activity.
[x] Don't show a "No Results" screen as soon as I start typing in the search field. It should only show that after a search response comes back from the server. I think doing this one will be slightly complicated.
[ ] If the screen is in the middle of a scrolling animation when a refresh finishes, don't suddenly stop scrolling. It'd probably be better behavior to insert rows for new stories into the existing table instead of wiping the whole table when it finishes updating. This may not be compatible with how we currently refresh stories in the model.

Gallery

[x] Image area should extend under the status bar. That should keep it from jumping 20 pixels when the chrome hides too.
[x] Hiding and showing the UI should be a quick fading transition, not a step change.
[x] Images shared via email should include a link to the story on the MIT News website.