Fix merge error during testing against cache - Githubissues

MIT-PSFC / disruption-py

An open-source physics-based Scientific Framework for Disruption Analysis of Fusion Plasmas for AI/ML applications

https://mit-psfc.github.io/disruption-py/

MIT License

11 stars 0 forks source link

Fix merge error during testing against cache #309

Closed amdecker closed 2 months ago

amdecker commented 2 months ago

Problem

The test against cache threw an error when using a shot without cached sql data.

https://github.com/MIT-PSFC/disruption-py/issues/304

Proposed solution

A few small logic changes including

Do not attempt to merge an empty DataFrame with the time data
Do not use the intersection of the set of columns in fresh & cache data when one of them has no columns because the intersection would always be an empty set

Verification

Run

poetry run python tests/test_against_cache.py --shot 177985

And the test will say the comparison failed because Have fresh data and Missing cache data.

All other tests pass/xfail appropriately.