search

MIT-PSFC / disruption-py

An open-source physics-based Scientific Framework for Disruption Analysis of Fusion Plasmas for AI/ML applications
https://mit-psfc.github.io/disruption-py/
MIT License
11 stars 0 forks source link

Add build workflow #323

Closed gtrevisan closed 1 month ago

gtrevisan commented 1 month ago

revamp the Install workflow to become a Build workflow. current logic is running for:

The action should publish to PyPI only when triggered by a release. still, I thought it remains useful to test:

even for commits, so that we double check that no change in the code made the package impossible to build, either by creating an impossible-to-be-solved dependency checkmate (eg someone modifying project deps by hand), or by minor bugs (eg someone renaming the README.md and poetry failing to find it).

it could be simplified in case this build/build workflow wasn't adding anything to the other CI/CD tests. any suggestion is appreciated!

gtrevisan commented 1 month ago

thanks for the suggestion! here I'm heavily relying on poetry doing all the work, so I think we won't have any problems in replicating what poetry publish --build might do, but it's a good point (and references to have!) in case our publishing workflow gets more complicated in the future. :grin: