MIT-PSFC / disruption-py

An open-source physics-based Scientific Framework for Disruption Analysis of Fusion Plasmas for AI/ML applications

https://mit-psfc.github.io/disruption-py/

MIT License

11 stars 0 forks source link

Compute beta normalized for both old and new C-MOD shots #343

Closed yumouwei closed 2 weeks ago

yumouwei commented 2 weeks ago

Original problems

\efit_aeqdsk:betan is undefined for pre-2000 shots.
There's a separate betan computation in cmod/efit.py for pre-2000 shots written by someone, but the calculation is wrong.

Implemented changes

Adding get_beta_normalized function in cmod/physics.py. This method takes in beta_t, ip, aminor, & btor data from EFIT and computes beta_n using the same formulation as \efit_aeqdsk:betan. The output agrees with \efit_aeqdsk:betan for post-2000 shots.
Remove existing betan fetching & computation in cmod/efit.py.
Update CMOD output shape in examples/efit.py.

gtrevisan commented 2 weeks ago

@crea-psfc is it worth analyzing the same for DIII-D, as well? or is that always returned by its efit nodename, so no issue there?

crea-psfc commented 2 weeks ago

not aware of similar issues, but it's worth it to do a quick check. IMHO, EFIT is better maintained at DIII-D