Both this script and the precomputed mp_saddle_coeff_matrix.mat are missing!
get_efit_gaps
✅
Extremely messy function! Needs to compare line by line with MATLAB!
get_pefit_gaps
Skip, copy of get_efit_gaps
get_kappa_area
✅
get_pkappa_area
✅
get_pcs
➖
➖
Broken into get_pcs_parameters and get_pcs_powers.
get_pcs_parameters
✅
get_pcs_powers
✅
p_ecrh_rt, p_oh_rt, p_icrf_rt, rad_input_frac, & rad_loss_frac weren't implemented in the source MATLAB script.
get_prad_peaking
✅
get_mirnov_std
✅
get_n1rms_n2rms
✅
get_h98
✅
(...): auxiliary functions
TODO prior to the validation stage
[ ] get_n_equal_1_data, get_mirnov_std, and get_n1rms_n2rms all use a similar method to compute btor. Consider making it into a standalone physics method.
TODO at the validation stage
[ ] Verify MDS nodes
[ ] Verify units
[ ] Check similar EFIT addresses (e.g. \aout vs \aminor)
[ ] Check, add, or remove try-except logic.
[ ] interp1 extrapolation (e.g. in get_power)
[ ] Restructure repetitive code blocks to make things more efficient (e.g. get icrf power).
[ ] Divide by 0 error (e.g. greenwald_fraction, rad_input_frac)
[ ] get_p_ohm: replace 1.85 with r0 signal
[ ] n1rms, n2rms: database might have Mirnov_std stored in that column.
[ ] n1rms_normalized, n2rms_normalized: database might have Mirnov_std_normalized stored in that column
[ ] h98: database might have prad_peaking stored in that column
TODO after the validation stage
[ ] Modify get_heating_power() to make it compatible with both get_power() and get_pcs_power.
Status
efit.py
physics.py
mp_saddle_coeff_matrix.mat
are missing!get_efit_gaps
get_pcsget_pcs_parameters
andget_pcs_powers
.p_ecrh_rt
,p_oh_rt
,p_icrf_rt
,rad_input_frac
, &rad_loss_frac
weren't implemented in the source MATLAB script.TODO prior to the validation stage
get_n_equal_1_data
,get_mirnov_std
, andget_n1rms_n2rms
all use a similar method to computebtor
. Consider making it into a standalone physics method.TODO at the validation stage
\aout
vs\aminor
)interp1
extrapolation (e.g. inget_power
)get_p_ohm
: replace 1.85 with r0 signaln1rms
,n2rms
: database might have Mirnov_std stored in that column.n1rms_normalized
,n2rms_normalized
: database might have Mirnov_std_normalized stored in that columnh98
: database might have prad_peaking stored in that columnTODO after the validation stage
get_heating_power()
to make it compatible with bothget_power()
andget_pcs_power
.