Closed LimHyungTae closed 2 weeks ago
Hi @LimHyungTae technically it should be automatically downloaded!
Please see here. Though it is indeed a problem that it fails silently sometimes. https://github.com/MIT-SPARK/Kimera-Multi-LCD/blob/main/cmake/vocab_download.cmake
Thanks for taking your time in weekend, @yunzc
Yep it should be, but I found that it does not work now, and I've realized that
file(DOWNLOAD
https://drive.google.com/uc?export=download&confirm=9iBg&id=1N4y0HbgA3PHQ73ZxFJvy5dgvV_0cTBYF
${CMAKE_CURRENT_SOURCE_DIR}/vocab.zip
SHOW_PROGRESS
STATUS voc_download_success
TIMEOUT 60)
this block does not work as we intended. It generates a weird vocab.zip
file (i.e. vocab.zip
file should be around 30 MB, but it outputs weird lightweight vocab.zip
file).
I also tested the below code after manually putting the original vocab.zip
file, and it worked.
### Download and unzip the vocabulary file
message("[Kimera-Multi-LCD] Trying to download and unzip the vocabulary file...")
if(NOT EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/vocab/mit_voc.yml)
message("[Kimera-Multi-LCD] Downloading vocabulary file from drive.")
# file(DOWNLOAD
# https://drive.google.com/uc?export=download&confirm=9iBg&id=1N4y0HbgA3PHQ73ZxFJvy5dgvV_0cTBYF
# ${CMAKE_CURRENT_SOURCE_DIR}/vocab.zip
# SHOW_PROGRESS
# STATUS voc_download_success
# TIMEOUT 60)
set(voc_download_success True)
if(voc_download_success)
message("[Kimera-Multi-LCD] Unzipping vocabulary file...")
execute_process(COMMAND ${CMAKE_COMMAND} -E tar xzf ${CMAKE_CURRENT_SOURCE_DIR}/vocab.zip
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/)
# execute_process(COMMAND ${CMAKE_COMMAND} -E rm ${CMAKE_CURRENT_SOURCE_DIR}/vocab.zip)
else()
message(FATAL_ERROR "[Kimera-Multi-LCD] Failed to download vocabulary file. Please download manually.")
endif()
else()
message("[Kimera-Multi-LCD] Vocabulary file exists, will not download.")
endif()
What about updating that line using an address, not the Google Share link? For instance, here's an example that normally works:
https://github.com/url-kaist/Quatro/blob/82d034385eb43cd9566b83ca743b03cfb66cc653/CMakeLists.txt#L57
I guess the file address should be complete.
I tested it by making my repository (https://github.com/LimHyungTae/kimera-multi-vocab)
and run wget https://github.com/LimHyungTae/kimera-multi-vocab/raw/master/vocab.zip
,
and it successfully works!!! XD
As mentioned in https://github.com/MIT-SPARK/Kimera-Multi/issues/18, currently
vocab.zip
file is not automatically installed in thekimera_multi_lcd
directory, which leads to an error like that: