MIT-SPARK / Kimera-RPGO

Robust Pose Graph Optimization
BSD 2-Clause "Simplified" License
471 stars 133 forks source link

Feature/fix gnc api change #80

Closed nathanhhughes closed 2 years ago

nathanhhughes commented 2 years ago

There was an API change in GTSAM for GncParams to support python and matlab bindings (see here for the source of the changes). My second commit contains the actual fix (using decltype to infer the actual vector type in GncParams). It should work both pre and post gtsam change (I built against develop and 4edcb41ad3680a9d4f6ee2f829c8ffd49b2bdba8).

I also added some quick fixes to warnings in the core rpgo code (I left the max clique code base alone though). The last straggling warning results from here which isn't set when PCM is disabled. I think a sane default value is 0.0 there, but wasn't completely sure.