MIT-SPARK / TEASER-plusplus

A fast and robust point cloud registration library
MIT License
1.81k stars 344 forks source link

Minor modifications for better usuability #184

Closed LimHyungTae closed 6 months ago

LimHyungTae commented 6 months ago

Hello @jingnanshi , I'd like to do PR.

I modified two things:

LimHyungTae commented 6 months ago

Also, I want to change pcl::NormalEstimation<pcl::PointXYZ, pcl::Normal> normalEstimation; to pcl::NormalEstimationOMP<pcl::PointXYZ, pcl::Normal> normalEstimation; to make FPFH faster! (Since in the 64-channel LiDAR point cloud, using OMP boosts the speed)

LimHyungTae commented 6 months ago

I also enable getting normal vectors, which is the side-output of the procedure of FPFH. By doing so, the TEASER++ library can be more easily integrated with ROBIN

LimHyungTae commented 6 months ago

Also, I fix the equal error in #177

jingnanshi commented 6 months ago

All good except the missing new line character

LimHyungTae commented 6 months ago

I did not know the importance of the new line at the end of the files. Here are my modifications:

jingnanshi commented 6 months ago

@LimHyungTae thanks! merging