search

MITEcology / feasibility_analysis

R package for feasibility analysis in ecology
MIT License
6 stars 3 forks source link

Keep minimal dependencies #4

Closed cy-long closed 1 year ago

cy-long commented 1 year ago

There are one dependency that is used only twice in several new functions:

#' @importFrom matlib inv

And when I call matlib on my machine, it causes errors. I believe it is related to the fact that matlib also has 3D visualization functions, which depend on the rgl package and XQuartz on macOS. Missing these environments causes errors.

To my understanding, we are usingmatlib::inv in only two places to inverse a matrix. If there's no special needs on that (for example, if matlib::inv is the only one that could deal with this type of matrix inversion), I would recommend using pracma::inv.

cy-long commented 1 year ago

For the moment, I already replacedmatlib::inv with pracma::inv in commit 97d55f4

ibartomeus commented 1 year ago

Great idea, the lighter the package, the better. It also took me a while to install rgl properly.