search

MITHaystack / srt-py

BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

Offsets for motor control #18

Open imyxh opened 10 months ago

imyxh commented 10 months ago

Hi, I noticed that srt-py wasn't sending the right coordinates to the motor, and fixed them in this commit to my fork: https://github.com/imyxh/srt-py/commit/ed6d110a972cf14d4686200b1e008e877a8373b4

I'm curious about the +0.5° that you're doing, and the fact that you send [az,el] relative to the limits. This seems to be incorrect at least for our motor. Is this something that varies across models?

AlexKurek commented 4 months ago

0.5 seems to be to prevent rounding down - a leftover from C. In Python maybe math.ceil() would be better.