MITHaystack / srt-py

BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

Scan center not updated during scan #25

Open AlexKurek opened 5 months ago

AlexKurek commented 5 months ago

The scan centre is not updated during the scan: https://github.com/MITHaystack/srt-py/blob/master/srt/daemon/daemon.py#L183 The sky is moving at 0.251 deg/min, so this can cause the Gaussian maximum to drift out of position.

AlexKurek commented 5 months ago

in case of Sun:

first scan_center: (173.53390817568615, 43.42817382314519) 0 of 25 point scan. current ephemeris_locations: (173.53390817568615, 43.42817382314519) [...] 24 of 25 point scan. current ephemeris_locations: (177.652692835991, 43.57928298515246)

For a test object close to STOW: Figure_1

and when I move scan_center = self.ephemeris_locations[object_id] inside the loop: Figure_1

This is how much the object moves during the scan: Figure_1

and when I move scan_center = self.ephemeris_locations[object_id] inside the loop: Figure_1

Zoom: Figure_2 It shows that the integration time and sleewing delay can be neglected.

AlexKurek commented 5 months ago

Fixed in: https://github.com/AlexKurek/srt-py/commit/c658cfe706f7798880b21ccd9f895bd199d2348f This is how it looks now in my fork: Screenshot from 2024-05-04 09-29-00

AlexKurek commented 3 months ago

The same for beam switch. Fixed in https://github.com/AlexKurek/srt-py/commit/9a35f6f9fb53828c48f6c7dd542ffd9daf34e9f4.