search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

The category breadcrumb is showing specific posts #100

Closed PBruk closed 8 years ago

PBruk commented 8 years ago

Tagging @frrrances for code-review: create breadcrumb template for categories and add to category templates. Resolves #97.

frrrances commented 8 years ago

i'm not familiar enough with WP to do this review. @matt-bernhardt can you review?

matt-bernhardt commented 8 years ago

This is close, but not quite right. I'll adjust.

matt-bernhardt commented 8 years ago

Kind of odd to review my own commit, but what I changed was:

a) swapping from esc_html__() to esc_url() in the breadcrumb partial. It doesn't make sense to use a translating function in this context, as URLs aren't subject to translation. Also, the WP codex gives the example of using esc_url() - https://codex.wordpress.org/Function_Reference/home_url

b) fixing code indenting. This required a second "Oops" commit because I missed what level CodeClimate would want (guessed it would want two tabs, it actually wanted one). I tried squashing this into one commit, but ran into problems - I think because I'm appending onto some work of Phillip's.

At any rate, this should now be ready to merge.

frrrances commented 8 years ago

green checks look good! 👍