search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

switch category and date tags and color #110

Closed frrrances closed 8 years ago

frrrances commented 8 years ago

This PR switches the date and categories tags on the post excerpt view to give more room for categories, and adjusts the color to be a11y friendly. Fixes #108

Code review: @matt-bernhardt

matt-bernhardt commented 8 years ago

Can you look at the tabs-v-spaces thing in CodeClimate? The indenting issues are finnicky and I'm fine with ignoring them. The unescaped output thing would be good to fix, but that problem exists throughout the theme - so this one instance won't make or break us.

Also, this isn't related to this PR, but the if/then structure around post author, date, and comments has an unanticipated condition (date and comments, but no author). I'm not worried as we don't usually enable comments, but something to watch for in the future I guess.

frrrances commented 8 years ago

@matt-bernhardt Yeah, that whole conditional is awkward but I'm not too concerned about it now. We'll need to do a lot of overhaul if we enable comments so I'm okay with leaving it, unless you feel strongly.

frrrances commented 8 years ago

Yeah, I'll rebase first.