search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Exhibit updates to use excerpt field #124

Closed hllavina closed 7 years ago

hllavina commented 7 years ago

addresses #118 uses excerpt field to display on exhibits summary

frrrances commented 7 years ago

Looks good! This is an add-on so feel free to push back, but would it be possible to have the cards use the beginning of the main content area if the excerpt isn't set?

hllavina commented 7 years ago

Yes, I have updated the field to use the content area if the excerpt field is not populated. i updated dev

frrrances commented 7 years ago

Nice! I just noticed one more thing... can we limit the excerpt to 500 characters max?

hllavina commented 7 years ago

We could cut off at 500 characters but I'd suggest considering leaving it up to the content editors to judge length. the character count include counts of html formatting and links as well as text since the field is not stripping them out,a character count may be long but the resulting text would be short if it includes paragraph tags and links and images

frrrances commented 7 years ago

Makes sense!

hllavina commented 7 years ago

Yikes I misread the checks , should all be fixed now

frrrances commented 7 years ago

This might be a good PR to try a rebase cleanup on the commit history :)