search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Add option to customizer for slim header #138

Closed hllavina closed 7 years ago

hllavina commented 7 years ago

What does this PR do?

This adds an option to customizer for the site to have a 'slim' header or header with menu. If menu is selected, it uses the default header which inherits from the parent.

How can a reviewer manually see the effects of these changes?

This change can be reviewed on any of the test sites using the child theme http://libraries-dev.mit.edu/exhibits/ http://libraries-dev.mit.edu/akdc http://libraries-dev.mit.edu/collections

Note - to use customizer, you need to first deactivate ACF Pro

What are the relevant tickets?

There are no direct tickets but this enhancement was born out of the ticket to modify the MOH header but the MOH site will not be using the child theme at this tiem

Todo:

Requires new or updated plugins, themes, or libraries?

NO

Requires change to deploy process?

NO

frrrances commented 7 years ago

@hllavina I see that ACF Pro has to be deactivated to use the Customizer - is that just to set it up the site with the header or do those two plugins not work together at all?

hllavina commented 7 years ago

regarding ACF and the customizer, mid august we discussed this and explored options When ACF is activated, the customizer will not save or preview, this has no relation to the new menu option that was added to the customizer but is the case on all sites using ACF. I located the bug causing this in ACF and talked to their support several times. The issue is our version of PHP , ACF needs a minimum of 5.6 and we are using 5.3.3. ACF won't fix this to support 5.3 and we can't downgrade the plugin version because there may be issues with our version of wordpress 4.8.1. the only option is upgrade PHP which is a project in progress. Meanwhile whenever we want to use the customizer for anything we need to deactivate ACF and then reactivate when done

matt-bernhardt commented 7 years ago

Please disregard the Travis failures on this - there's no way that this change has caused the problems that are being flagged. It looks like Travis may have updated what standards they're applying, which introduced a new test that was previously unused.

I've also exempted the two failures in CodeClimate (making variable names comply with standards is a bigger project than this PR).

frrrances commented 7 years ago

@hllavina thanks for the extra context - I saw that conversation but wasn't entirely clear on the repercussions.