MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Remove spaces around object operators #140

Closed matt-bernhardt closed 7 years ago

matt-bernhardt commented 7 years ago

Status

Use labels (review needed, in progress, or paused) to declare status

What does this PR do?

This resolves a recently-appearing violation in Travis/PHPCS that has to do with spacing around object operators. While in many cases coding standards call for spacing around just about everything, this is one case where foo->bar is more appropriate than foo -> bar.

Helpful background context (if appropriate)

While we don't use all of the PSR-2 standard, their example code does show what I think we're looking for at this URL:

http://www.php-fig.org/psr/psr-2/#11-example

How can a reviewer manually see the effects of these changes?

This should have no visible effect - but the tests on Travis should now pass. The affected templates are the single post display and the category breadcrumb - so if pages using those templates still work, there will be no side effect.

One path to check, that uses single.php, is to visit /libtest/2016/02/sample-openseadragon-gallery and verify that the page loads, categories are visible, and What The File reports the use of single.php.

I'm having a hard time finding a page that uses inc/breadcrumbs-category.php

What are the relevant tickets?

Todo:

Requires new or updated plugins, themes, or libraries?

NO

Requires change to deploy process?

NO