MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Font awesome icons are not showing correctly #15

Open frrrances opened 8 years ago

frrrances commented 8 years ago

All FA icons are showing up as boxes on production child and news:

Not showing: http://libraries.mit.edu/news/subscribe/ http://libraries.mit.edu/giving/

Showing: http://libraries.mit.edu/barker/

Suggested fix: Convert font-awesome to CDNs and add support for FA4.

FA3 CDN:

FA4 CDN (we need to sign up): http://fontawesome.io/get-started/

Because of the syntax change between 3 and 4 (icon- prefix vs fa- prefix), we want to include both until we can convert over the icons in use, unless there is some problem with having both.

PBruk commented 8 years ago

To get the actual social media icons to appear, not just chevron-circle-right, this HTML needs to be added to widget, with a widget css class of "connect-widget" :

> <div>
> <span class="twitter-connect"><a href="#">[twitter-handle-goes-here]</a></span >
> <span class="fb-connect"><a href="#">[facebook-name-goes-here]</a></span>
> <span class="email-connect"><a href="#">[email-address-goes-here]</a></span>
> </div>

I will add other social media icons to the sidebar.scss file, as well, such as instagram and pinterest and... whatever other options might be needed. So those will be called the same, just replace social media type, as needed in span class that calls the icon.

frrrances commented 8 years ago

@PBruk Thanks for investigating social icons in the sidebar, but for this story we just want to get the basic icons working the same in parent and child on production. The last release caused a reversion where the icons aren't working on the child sites. I think the plan we discussed - to add the CDN to parent - is a good direction to start with.