MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Removes create_function call to prepare for PHP 7.2 #152

Closed matt-bernhardt closed 4 years ago

matt-bernhardt commented 4 years ago

Status

Use labels (review needed, in progress, or paused) to declare status

What does this PR do?

This refactors the application of a filter in functions.php to avoid a deprecated PHP function, create_function().

Helpful background context (if appropriate)

There's a ton of background links in the Jira ticket. Ultimately, this should be a pretty simple refactor if the examples I'm finding are applicable.

How can a reviewer manually see the effects of these changes?

The Special Collections site has a variety of slideshows that trigger warnings in our logs. Tailing the error log while visiting these pages should show now messages that refer to a deprecated create_functions call.

What are the relevant tickets?

Screenshots (if appropriate)

Todo:

Requires new or updated plugins, themes, or libraries?

YES | NO

Requires change to deploy process?

YES | NO