search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Adds grunt build process for version strings #20

Closed matt-bernhardt closed 8 years ago

matt-bernhardt commented 8 years ago

Code review:

FYI to @szendeh after his help working out how to implement this.

This implements the ability to populate the theme's version string with the branch and latest commit SHA. It does this by adding a build step, completed on the server, as part of the deploy process.

The cost of this is that the stylesheet moves from /style.css to /css/style.css. Down the road, if we end up using SASS or LESS or some other compiler, even more changes will be necessary.

What say you all?

PBruk commented 8 years ago

Code reviewed. LGTM + 1. And I say yes to the proposed/possible changes to CSS.

frrrances commented 8 years ago

I'm cool with the move of style.css if you don't think it will impact anything, and the improvement is pretty valuable. 👍

matt-bernhardt commented 8 years ago

Squashing and merging after two positive comments