MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Clean-up page--- templates #79

Open PBruk opened 8 years ago

PBruk commented 8 years ago

Some of the code was written in haste (by me) and is inefficient and needlessly repetitive.

matt-bernhardt commented 8 years ago

I agree with making code non-repetitive, and in cleaning up code - but I'm finding this a bit too vague to be really actionable. Can you edit the description of the issue more specific? Are there templates that you think need attention the most, or is there a certain kind of problem that needs to be corrected?

PBruk commented 8 years ago

Matt, good question. It was actually your review of one of my PRs which forced me to rethink my template re-write, which I am referring to here regarding these other templates. Here is an example of what I am referring to:

page php

Instead of this:

page-front php