search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Exhibits listing issues #92

Closed PBruk closed 8 years ago

PBruk commented 8 years ago

Tagging @matt-bernhardt or @frrrances for code-review: adjusted queries for current, upcoming and past exhibit loops to display posts properly within their respective timeframe; resolves #85.

matt-bernhardt commented 8 years ago

Generally speaking, I'd pay attention to the analysis results from CodeSniffer and CodeClimate - both are throwing errors, sometimes for easily-fixed formatting. I've included the CodeSniffer output below for reference, but the links to the full report can be found below.

I think the actual changes in this PR seem okay, as long as @frrrances signs off on their effects. The diff is a little muddled right now because of the formatting changes.

FILE: ...content/themes/MITLibraries-child/category-maihaugen-gallery.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 40 | ERROR | [x] Whitespace found at end of line
    |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../wp-content/themes/MITLibraries-child/category-rotch-library.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 40 | ERROR | [x] Whitespace found at end of line
    |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../src/wp-content/themes/MITLibraries-child/page-exhibits-feed.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 40 | ERROR | [x] Whitespace found at end of line
    |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
frrrances commented 8 years ago

@matt-bernhardt I fixed the tests so I think this branch is ready to go. Its up on -dev if you want to review.