search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

Single page issues #93

Closed PBruk closed 8 years ago

PBruk commented 8 years ago

Tagging @matt-bernhardt or @frrrances for code-review: create exhibits-specific single-post template (might be overkill, might be useful, open to discussion). Resolves #84.

matt-bernhardt commented 8 years ago

Does this actually address all the aspects of #84? I see that it removes the "News" line, but no changes to the post date or header image are immediately visible?

FWIW, I'm not concerned about the CodeClimate issues in this case - the two issues are the outcome of a very zealous check for duplicate code. Unsurprisingly, it found a lot of similarities between single.php and single-exhibits.php

frrrances commented 8 years ago

@PBruk I think having a separate template is the best solution. I also updated the issue with more details since I found an old screenshot that shows what info used to be on the page. Can you make those updates to this PR?

frrrances commented 8 years ago

👍