search

MITLibraries / MITLibraries-child

A Wordpress child theme that descends from MITLibraries-parent
GNU General Public License v3.0
1 stars 1 forks source link

adjust button styles and add music button #94

Closed frrrances closed 8 years ago

frrrances commented 8 years ago

This PR adjusts some button styles and adds a new music button.

code review: @matt-bernhardt

matt-bernhardt commented 8 years ago

CodeClimate flagged a possible performance hit from the *= selector on line 1090, but given that it is a reset I'm not sure that's avoidable. LGTM.

As an aside, I'm impressed that FontAwesome uses /f001 for its music note - that's quite an auspicious number.

frrrances commented 8 years ago

@matt-bernhardt - yeah I agree that selector is nasty. I adjusted my code and though it won't directly override the parent, I think it should work as long as we add the exact "button-primary" class when we want this override.

Also, I thought it was cool the music note was 001 too! But I forgot that I wanted to use the speaker icon so now it's 028.

matt-bernhardt commented 8 years ago

:shipit: