MITLibraries / MITlibraries-parent

The parent theme for MIT Libraries on WordPress
https://libraries.mit.edu
GNU General Public License v3.0
1 stars 3 forks source link

Styling changes #292

Closed matt-bernhardt closed 5 years ago

matt-bernhardt commented 5 years ago

Status

Use labels (review needed, in progress, or paused) to declare status

What does this PR do?

This implements three changes in styling by the theme:

  1. It extends the styling for web forms to the theme's default template. This is needed for an imminent site release that will implement forms on a child theme to this theme, allowing that site to have access to these styles while still preserving the site branding.

This also sets up a future change wherein the forms template might be superfluous, and all forms can just be placed on the standard template - but we'll get there later.

  1. It adds brand-specific styling for tables. Because there are various tables already on the site whose impact is unknown, we've scoped these changes to a class applied to the table - table.pentagram - which future tables will use, and can be backported to existing tables as needed.

A separate part of this change is a second table class that is meant for tables of numbers, wherein cell contents should be right-aligned.

  1. It adds two classes for sidebar widgets: no-top-border and collapse-top-margin which will allow adjacent widgets to appear as one element. One of these classes is being transferred up from the child theme, having already been defined there but now being needed on the parent theme.

How can a reviewer manually see the effects of these changes?

See Matt for URLs

What are the relevant tickets?

Screenshots (if appropriate)

Forms without styling: image

Forms after styling: image

Table without pentagram class: image

Table with pentagram class: image

Sidebar without new widget classes: image

Sidebar with new widget classes: image

Todo:

Requires new or updated plugins, themes, or libraries?

NO

Requires change to deploy process?

NO