MITLibraries / MITlibraries-parent

The parent theme for MIT Libraries on WordPress
https://libraries.mit.edu
GNU General Public License v3.0
1 stars 3 forks source link

Improves a11y of header logo hover/focus #318

Closed matt-bernhardt closed 4 years ago

matt-bernhardt commented 4 years ago

Status

Use labels (review needed, in progress, or paused) to declare status

What does this PR do?

This will improve the highlighting applied to the Libraries and MIT logos in the header, by matching that applied to the rest of the header links.

Helpful background context (if appropriate)

This is follow-on work from the a11y review that was conducted last December.

How can a reviewer manually see the effects of these changes?

These changes are currently deployed to the staging server.

What are the relevant tickets?

Screenshots (if appropriate)

Before change:

Screen Shot 2020-03-31 at 9 22 40 AM Screen Shot 2020-03-31 at 9 22 45 AM

After change: Screen Shot 2020-03-31 at 12 56 38 PM Screen Shot 2020-03-31 at 12 56 42 PM

Todo:

Requires new or updated plugins, themes, or libraries?

NO

Requires change to deploy process?

NO

matt-bernhardt commented 4 years ago

Darcy has approved the changes in the linked Jira ticket late yesterday, so we should be ready to deploy after code review.