MITLibraries / MITlibraries-parent

The parent theme for MIT Libraries on WordPress
https://libraries.mit.edu
GNU General Public License v3.0
1 stars 3 forks source link

Refactor OpenGraph attributes #323

Closed matt-bernhardt closed 4 years ago

matt-bernhardt commented 4 years ago

Status

Use labels (review needed, in progress, or paused) to declare status

What does this PR do?

This takes our OpenGraph meta tags from header.php and creates a new partial, inc/header-opengraph.php. This partial makes some changes, and also sets up additional overrides by the News theme without needing to fork the entire header:

The Libraries' network logo is always used as the image.

Please note: this is part of two coordinated PRs. The other is MITLibraries/MITLibraries-news#129. The Child theme is not currently implementing an override to these templates.

How can a reviewer manually see the effects of these changes?

This branch has been deployed to staging. It should result in no visible changes. To see the difference, compare the behavior of Slack or Facebook when sharing URLs from the staging server.

https://developers.facebook.com/tools/debug/ is a useful tool for previewing how Facebook will see these attributes. You can also paste a URL directly into Slack and see how it appears there.

What are the relevant tickets?

Todo:

Requires new or updated plugins, themes, or libraries?

YES - this PR anticipates the successful deploy of the related PR in the News theme.

Requires change to deploy process?

NO