MITLibraries / MITlibraries-parent

The parent theme for MIT Libraries on WordPress
https://libraries.mit.edu
GNU General Public License v3.0
1 stars 3 forks source link

Replacing existing footer with one from design system #328

Closed matt-bernhardt closed 4 years ago

matt-bernhardt commented 4 years ago

This aims to replace our existing footer with the markup and styles from the design pattern, following MITLibraries/mitlib-style#94.

Helpful background context (if appropriate)

This stands in opposition to #329, which attempts to make the same update using a minimal changeset.

How can a reviewer manually see the effects of these changes?

What are the relevant tickets?

Screenshots (if appropriate)

Todo:

Requires new or updated plugins, themes, or libraries?

YES | NO

Requires change to deploy process?

YES | NO

matt-bernhardt commented 4 years ago

This is a screenshot of what this branch looks like on my local Dockerized WordPress application:

Screen Shot 2020-09-28 at 12 50 34 PM

matt-bernhardt commented 4 years ago

After discussions within EngX, we have decided to go with the other of the two options, going with a minimal change to our existing theme.