MITLibraries / MITlibraries-parent

The parent theme for MIT Libraries on WordPress
https://libraries.mit.edu
GNU General Public License v3.0
1 stars 3 forks source link

Replicates some list styling from ul to ol elements #334

Closed matt-bernhardt closed 3 years ago

matt-bernhardt commented 3 years ago

What does this PR do?

This copies a block of styles that was previously defined for unordered lists, and applies them to ordered lists. The rule directly above this change contains four rules for .entry-content ul li conditions. Three of them are now applied to .entry-content ol li conditions (the fourth assigns a disc bullet style, which is inappropriate for ordered lists)

Helpful background context (if appropriate)

Frankly, the way our styles are defined and flow from parent to child themes right now is kind of a mess. Straightening everything out promises to be a bit of a nightmare, so right now we're just tactically fixing this one problem.

How can a reviewer manually see the effects of these changes?

This branch has been deployed to staging (link not included here, ask on Slack)

What are the relevant tickets?

Screenshots (if appropriate)

Before: Screen Shot 2020-11-30 at 4 15 56 PM

After: Screen Shot 2020-11-30 at 4 15 41 PM

Todo:

Requires new or updated plugins, themes, or libraries?

NO

Requires change to deploy process?

NO