search

MITLibraries / oastats-ui

The User Interface for the MIT Libraries Open Access Statistics Project
0 stars 2 forks source link

Adds separate credentials file #134

Closed matt-bernhardt closed 9 years ago

matt-bernhardt commented 9 years ago

Signed-off-by: Matt Bernhardt mjbernha@mit.edu

matt-bernhardt commented 9 years ago

Tagging @JPrevost in case you aren't already

matt-bernhardt commented 9 years ago

In the past we've had the dev and test applications pointing at a dev database server that had faked data. For the moment, we've got them all set to pull live data to make tuning the visualizations more realistic; would you recommend changing this strategy and just get better faked data in the dev db server?

I've used the flexibility this approach offers in the past, being able to point different environments at different data sources - even if currently that isn't the case.

JPrevost commented 9 years ago

If this does what you want, then :+1: from me.

My personal thoughts on how to handle what you want to do (if I understand it) would be to have a single $mongo["server_url_or_whatever"] in your credentials.php file and then just change that value to whatever you want whenever you want. That allows for removing all of the cases from the code while still maintaining the same amount of flexibility (the flexibility is now in the config file instead of the code).

I assume all the mongo stuff is read only for this app so point at prod seems fine from dev/test/local in general too.